feat(instrumentation-hapi): support migration to stable HTTP semconv, v1.23.1 #2863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… v1.23.1 `instrumentation-hapi`, in addition to providing the HTTP route for the *HTTP* instrumentation, also generates hapi spans for each plugin/route. Attributes on these hapi spans include some covered by HTTP semantic conventions. This change adds support for controlled migration from the old to the stable HTTP semconv via the `OTEL_SEMCONV_STABILITY_OPT_IN` envvar. See https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/ This also updates from the deprecated `SpanAttributes` api type to `Attributes`. Refs: open-telemetry/opentelemetry-js#5663 (HTTP semconv) Refs: open-telemetry/opentelemetry-js#4175 (Attributes)
github-actions
bot
added
the
pkg-status:unmaintained
17 tasks
Contributor
Author
|
This also handles #2377 for instrumentation-hapi. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2863 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 185 186 +1
Lines 9034 9048 +14
Branches 1852 1855 +3
=======================================
+ Hits 8103 8116 +13
- Misses 931 932 +1
🚀 New features to boost your workflow:
|
Contributor
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
trentm
added
the
has:sponsor
david-luna
approved these changes
Jun 2, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instrumentation-hapi, in addition to providing the HTTP route for theHTTP instrumentation, also generates hapi spans for each plugin/route.
Attributes on these hapi spans include some covered by HTTP semantic
conventions.
This change adds support for controlled migration from the old to the
stable HTTP semconv via the
OTEL_SEMCONV_STABILITY_OPT_INenvvar. Seehttps://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/
This also updates from the deprecated
SpanAttributesapi type toAttributes.Refs: open-telemetry/opentelemetry-js#5663 (HTTP semconv)
Refs: open-telemetry/opentelemetry-js#4175 (Attributes)